33 lines
2.7 KiB
Markdown
33 lines
2.7 KiB
Markdown
|
# Review
|
||
|
|
|
||
|
|
For /FD-review. Apply core rules and the REVIEW protocol stage. Use actual inspection tools; reviewed code/configuration remains read-only by default. Track a complex review using [todo.md](todo.md) without treating findings as approved fixes.
|
||
|
|
|
||
|
|
## Select evidence
|
||
|
|
|
||
|
|
Accept selected changes, files, behavior, implementation/plan comparison, or a bounded existing-code audit. Read requirements, the effective plan, and task record. A missing plan does not prevent review; do not invent a baseline.
|
||
|
|
|
||
|
|
With Git, inspect relevant diffs, context, and callers. Without Git, inspect specified files, available comparisons, or reproducible behavior. Ask about ambiguous targets instead of scanning the entire project.
|
||
|
|
|
||
|
|
## Review applicable concerns
|
||
|
|
|
||
|
|
- Requirements: acceptance, omissions, and unrelated changes.
|
||
|
|
- Correctness/regression: triggers, boundaries, state transitions, failure handling, and caller impact.
|
||
|
|
- Evidence: real APIs/configuration/dependencies, pre-existing versus new failures, behavior-based assertions, and whether the original defect was actually retested.
|
||
|
|
- Maintenance: reuse, necessary abstractions, and correct responsibilities.
|
||
|
|
- Relevant risks: data, permissions, resources, affected old callers/configurations/files, migration/restoration, or release impact as applicable.
|
||
|
|
- User path: the requested observable result works across necessary layers; mocks or generated parts do not prove integration.
|
||
|
|
- UI: approved action states and recovery, the product-copy boundary from [uiux.md](uiux.md), unrequested adjacent commentary, and accidental removal of actual labels/status/errors.
|
||
|
|
- Delivered artifact: where packaging is in scope, distinguish a built file from the package actually started and exercised.
|
||
|
|
|
||
|
|
Judge plan differences by their actual impact, not wording alone. Investigate real trigger paths and constraints that could disprove each suspicion.
|
||
|
|
|
||
|
|
Run targeted tests, builds, or static checks when appropriate. Checks may produce caches, build artifacts, and reports, not rewrite source, snapshots, configuration, or real data. Avoid formatters, update modes, migrations, and publication. Existing task records may receive review findings when permissions allow.
|
||
|
|
|
||
|
|
## Output and stop
|
||
|
|
|
||
|
|
In Chinese, report actionable issues with location, evidence, trigger, actual impact, priority, and a necessary fix direction. Distinguish confirmed defects, accepted tradeoffs, and unverified hypotheses.
|
||
|
|
|
||
|
|
Order by impact; do not dilute issues with stylistic preferences. If none are found, state scope, checks, and limitations without claiming defect-free code.
|
||
|
|
|
||
|
|
Finish the agreed review. Fix only after an explicit request and applicable plan/authorization; this command alone does not authorize fixes, staging, or commits.
|